I wanted to override some of the default run-regress-* targets by
declaring them in regress Makefiles. Many tests already do that and
it happens to work as expected.
However, this relies on behavior in the BUGS section of make. In fact,
espie informs me that gmake behaves the other way around and honors the
last definition (gmake also warns about redefinitions).
To avoid this, I'd like to have bsd.regress.mk define these default
targets only if they aren't already defined. This matches most targets
in the other *.mk files.
I kept the .PHONY target outside of the .if block since most regress
Makefiles don't use .PHONY at all although they often should. In fact,
none of the run-regress-* targets I looked at were marked phony.
Index: share/mk/bsd.regress.mk
===================================================================
RCS file: /cvs/src/share/mk/bsd.regress.mk,v
retrieving revision 1.24
diff -u -p -r1.24 bsd.regress.mk
--- share/mk/bsd.regress.mk 31 Aug 2021 23:33:05 -0000 1.24
+++ share/mk/bsd.regress.mk 2 Dec 2022 11:54:43 -0000
@@ -32,8 +32,10 @@ _REGRESS_TMP?=/dev/null
_REGRESS_OUT= | tee -a ${REGRESS_LOG} ${_REGRESS_TMP} 2>&1 > /dev/null
.for p in ${PROG} ${PROGS}
+. if !target(run-regress-$p)
run-regress-$p: $p
./$p
+. endif
.PHONY: run-regress-$p
.endfor
