On Thu, Dec 01, 2022 at 09:50:47PM +0300, Vitaliy Makkoveev wrote:
You could also document these globals with [I] in kern_proc.c
LIST_HEAD(uihashhead, uidinfo) *uihashtbl;
u_long uihash; /* size of hash table - 1 */
OK bluhm@
> Index: sys/sys/proc.h
> ===================================================================
> RCS file: /cvs/src/sys/sys/proc.h,v
> retrieving revision 1.335
> diff -u -p -r1.335 proc.h
> --- sys/sys/proc.h 23 Nov 2022 11:00:27 -0000 1.335
> +++ sys/sys/proc.h 1 Dec 2022 18:48:47 -0000
> @@ -303,6 +303,7 @@ struct p_inentry {
> * Locks used to protect struct members in this file:
> * I immutable after creation
> * S scheduler lock
> + * U uidinfolk
> * l read only reference, see lim_read_enter()
> * o owned (read/modified only) by this thread
> */
> @@ -433,10 +434,10 @@ struct proc {
> #ifdef _KERNEL
>
> struct uidinfo {
> - LIST_ENTRY(uidinfo) ui_hash;
> - uid_t ui_uid;
> - long ui_proccnt; /* proc structs */
> - long ui_lockcnt; /* lockf structs */
> + LIST_ENTRY(uidinfo) ui_hash; /* [U] */
> + uid_t ui_uid; /* [I] */
> + long ui_proccnt; /* [U] proc structs */
> + long ui_lockcnt; /* [U] lockf structs */
> };
>
> struct uidinfo *uid_find(uid_t);
