On Mon, Mar 27, 2023 at 09:59:47AM +0200, Jan Klemkow wrote: > On Fri, Mar 24, 2023 at 10:02:05PM +0100, Theo Buehler wrote: > > > Thus, I would suggest to set this constant to ELAST. So, we will avoid > > > useless unknown error strings and a non-zero errno after tls_init(). > > > > ELAST isn't portable. It's under __BSD_VISIBLE in sys/errno.h. > > > > It would seem better to use the save_errno idiom to store the errno > > at the start of the loop and restore it at the end. > > > > And yes, we should fix this, after unluck. > > ok?
I would leave out the initialization at the declaration of save_errno. The comment is not strictly needed, but feel free to keep it. ok
