On Tue, Mar 28, 2023 at 11:33:11AM +0200, Claudio Jeker wrote: > On Tue, Mar 28, 2023 at 11:00:37AM +0200, Theo Buehler wrote: > > On Tue, Mar 28, 2023 at 10:35:34AM +0200, Claudio Jeker wrote: > > > Switch mrt_dump_entry_v2() to use a dynamic ibuf for the prefix and > > > switch the order of operation so that the memmove() of pbuf is no longer > > > needed. Using a static buffer is problematic when flowspec support is > > > added since flowspec "prefixes" can be more than 255 bytes long. > > > > Reads fine. > > > > ok > > > > DUMP_SHORT() uses htons() instead of ntohs(), but those are different > > names for the same thing unless I'm totally fooling myself. > > Yes, on all systems we support htons() and ntohs() are interchangeable. > Plus the use of ntohs() in the old code was actually wrong. The afi > returned by aid2afi is in host byte order and needs to be translated to > network byte order.
I agree with all of that. Thanks. > > -- > :wq Claudio
