> On 6 Jun 2023, at 19:37, Chris Cappuccio <ch...@nmedia.net> wrote: > > Jan Klemkow [j.klem...@wemelug.de] wrote: >> On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: >>> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: >>>> I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe >>>> it's just because I had to type that long name too often. >>>> >>>> With that we have consistent naming: >>>> # ifconfig ix0 tcplro >>>> # sysctl net.inet.tcp.tso=1 >>>> >>>> Also the coresponding flag are named LRO. >>>> # ifconfig ix1 hwfeatures >>>> ix1: flags=2008843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,LRO> mtu 1500 >>>> >>>> hwfeatures=71b7<CSUM_IPv4,CSUM_TCPv4,CSUM_UDPv4,VLAN_MTU,VLAN_HWTAGGING,CSUM_TCPv6,CSUM_UDPv6,TSOv4,TSOv6,LRO> >>>> hardmtu 9198 >>>> >>>> The feature is quite new, so I have no backward compatiblity concerns. >>>> >>>> ok? >>> >>> Could you name it "lro" like FreeBSD uses? >> >> I also would prefer this one. > > and tcpsendoffload back to tso ? > > was the reason for changing it from tso due to the initial conflation of TSO > and LRO in the tree? >
This tso not the tcpsendoffload, and yes, we used tso before it became global net.inet.tcp.tso.
