On Sun, Sep 24, 2023 at 03:17:11PM +0200, Claudio Jeker wrote:
> Try to document how REGRESS_LOG and REGRESS_FAIL_EARLY interact.

We could make it fully precise with a few more words.

> 
> -- 
> :wq Claudio
> 
> Index: bsd.regress.mk.5
> ===================================================================
> RCS file: /cvs/src/share/man/man5/bsd.regress.mk.5,v
> retrieving revision 1.24
> diff -u -p -r1.24 bsd.regress.mk.5
> --- bsd.regress.mk.5  31 Mar 2022 17:27:22 -0000      1.24
> +++ bsd.regress.mk.5  24 Sep 2023 13:15:27 -0000
> @@ -79,11 +79,20 @@ If this variable is set to anything but
>  the
>  .Cm regress
>  target will abort as soon as a test fails.
> +By default the value is

I'd go with the shorter form used elsewhere:

Defaults to

> +.Dq yes
> +unless
> +.Ev REGRESS_LOG
> +is set.
>  .It Ev REGRESS_LOG
>  Points to the fully-qualified path of a file to which regression
>  results are appended.
>  Defaults to
>  .Pa /dev/null .
> +If set
> +.Ev REGRESS_FAIL_EARLY
> +defaults to
> +.Dq no .

I'd spill the words to make it precise:

If set to any other path,
.Ev REGRESS_FAIL_EARLY
defaults to
.Dq no .

(not sure if grammar requires us to say "If REGRESS_LOG is set ...")

>  .It Ev REGRESS_ROOT_TARGETS
>  Targets for which root access is required to run the test.
>  The
> 

Reply via email to