http://bugs.freedesktop.org/show_bug.cgi?id=18832
Sunil Mohan Adapa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|patch | --- Comment #3 from Sunil Mohan Adapa <[email protected]> 2008-12-26 02:25:27 PST --- (In reply to comment #2) > I think you shouldn't use that method if you can still continue without dbus > connection. I didn't consider this because if in future, tp_get_bus changes is behavior, the application might break. Perhaps I should directly use dbus_g_get_bus. > Even with your patch you'll get a warning instead of a GError you > can report to the user. Yes, not returning the GError is not right. > > IMO in most telepathy programs failing at getting the dbus connection is fatal > because we can't do anything else (use g_assert instead of exit?). But I agree > that we could add another function that is non-fatal and return a GError > instead. Probably libempathy should use it too. For example, trying to send a > file to a contact from nautilus without dbus running shouldn't terminate > nautilus, but an error could be displayed to the user. > -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Telepathy mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/telepathy
