Andre Magalhaes wrote: > Forwarding to the list > > ---------- Forwarded message ---------- > From: Kenneth Rohde Christiansen <[email protected]> > Date: Tue, Mar 24, 2009 at 4:04 PM > Subject: TelepathyQt > To: André <[email protected]> > > > Hi Andre, > > Saw your discussion on the mailing list, nice. > > I looked at some of your examples, nice stuff. I also saw that to use > the video stuff you need to use Gstreamer manually. Will there be any > convenience for this? > Looking at the code I wondered why you don' t use Qt coding style for > privates? > > + mPriv(new Private) >
Regarding mPriv, when I started working with tp-qt4, it was already this way, I really prefer using "d" pointers, as I am already used to it, and it follows qt coding style. Using d pointers we could also use qt macros as Q_D and related, but this is my personal opinion. Need to see what the other guys think. > Like using d and q pointers? Like the private is always called d and > it it initialized with its owner which is stores as q. > Also I saw that some places you have signals with the name Exposed, > normally Qt doesn't use exposed, but RepaintRequested etc. > Minor comments but anyway. > The gstreamer stuff is now only on the call example, but it will be moved to the library itself later when it gets complete. Thanks for the tips. BR Andrunko _______________________________________________ telepathy mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/telepathy
