Hi all,
I had reported a request feature about implementing
internationalization support (http://code.google.com/p/aost/issues/
detail?id=221&q=i18n), I see it's committed and documented for 0.7.0
snaphost(http://code.google.com/p/aost/issues/detail?id=221&q=i18n),
great ;-)
However, I have some concerns about implementation:
1. Management of multiple bundles is incorrect:
InternationalizationManager#translate() methods do not handle case
when bundle key is not found in some bundles, which makes this feature
unusable according to me: you can't aggregate distinct messages from
distinct bundles. This method should handle MissingResourceException.
2. You don't allow to specify language when asking for a translation.
It would be useful to be able to pass locale, either by adding
optional locale parameter in translate method (translate('msgKey',
Locale.FRENCH)), either by providing one InternationalizationManager
instance by locale
3. I find term 'translate' not totally relevant: it does not translate
something, it just provides value for specified key. I think these
methods should be named with someting like get()
4. method BaseTelluriumJavaTestCase#geti18nManager() does not respect
Java naming standard, it should be getI18nManager()
5. It would be useful to allow to set a custom implementation of
InternationalizationManager
Anyway, I go on with 0.7.0 snapshot, with patched implementation of
InternationalizationManager for #1 issue.
Sylvain
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"tellurium-users" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/tellurium-users?hl=en
-~----------~----~----~----~------~----~------~--~---
