On Fri, Aug 16, 2002 at 04:47:20PM +0900, Tatsuhiko Miyagawa wrote:
> So this patch adds new html_linebreak filter to do
> it. We always define this filter by ourselves, so I wish TT2 itself
> has it.

Looks good, with just a minor change of name.

I added it as html_line_break (rather than html_linebreak) and also 
added html_para_break as an alias to the existing html_break, for the
sake of completeness and consistency.

> -appropriate HTML entities (e.g. converting '?' to 'é').  If
> +appropriate HTML entities (e.g. converting '�' to 'é').  If

I noted your other email and duly ignored this line...

> +=head2 html_linebreak
> +
> +This filter replaces any newlines with E<lt>brE<gt> HTML tags.

One other point: the documentation for the modules is built from the 
docsrc tree (this is a separate distribution available from the website).
It's easiest for me if you can edit the docsrc files direct (in this
case, docsrc/lib/misc/filters) and send me patches against those.

Having said that, the whole docsrc tree is a mess and hard to figure out
where everything is.  Changing the documentation directly in the module 
file as you did is the second best way.  This is always preferable to not
patching the documentation at all :-)

Thanks for the patch.

Cheers
A


_______________________________________________
templates mailing list
[EMAIL PROTECTED]
http://www.template-toolkit.org/mailman/listinfo/templates

Reply via email to