* Josh Rosenbaum <josh at infogears.com> [2005/12/23 11:56]:
> Randal L. Schwartz wrote:
> > Yes, it's probably not cool to break things, but this is arguably
> > broken code already.
> 
> I wouldn't consider it broken, but just not malleable to other
> purposes. 

Well, Randal's point is that what the URL plugin produces is not a
URL, it's an HTML-escaped URL, and not every URL needs to be escaped.
(He's argued that point more forcefully in the past than he is now.)
When you need to insert that URL into an attribute -- and pretty much
only then -- does it need to be escaped, and every other use of the URL
should be "naked" and unencoded.

I do agree that breaking old code sucks, and that maybe a change so
radical as this one ("radical" being a relative term, of course) should
be reserved for the next major version of TT.

Maybe the right thing to do is to keep the change I've made (a
configurable joiner) and have it default to '&amp;'?  Also, can someone
give me a better name than "$JOINER"?  That's a pretty dumb name.

(darren)

-- 
The secret of life is enjoying the passage of time.
    -- James Taylor

_______________________________________________
templates mailing list
[email protected]
http://lists.template-toolkit.org/mailman/listinfo/templates

Reply via email to