Rafael Vanoni wrote: > Li, Aubrey wrote: >> Rafael.Vanoni wrote: >> >>> Li, Aubrey wrote: >>>> Hi Rafael, >>>> >>>> Rafael.Vanoni wrote: >>>> >>>>> Hey Aubrey, have you had a chance to review the last batch of >>>>> changes ? >>>>> Thanks, >>>>> Rafael >>>> More concerns besides the code, since this patch introduces a new >>>> user interface, do we need another PSARC? >>> I'm not sure, I have to ask around. >>> >>>> Recently, we fixed several critical bugs, I'm thinking if we can >>>> release ptop1.2 including the critical bug-fixes, and putback into >>>> ON soon. >>> I'm starting the process to put those fixes back into Nevada, but I'd >>> like to get this one too to save the extra work, and I also have >>> fixes for 8658 and 2861 on the way. >>>> I'd like to separate this patch into two, >>>> 1) display.c needs some lovin' >>>> 2) PowerTOP should allow the user to freeze its subwindows >>>> >>>> And I think 2) can be based on ptop1.2. >>>> >>>> What do you think? >>> I started with that, but implementing the freeze options >>> required a lot >>> of changes in display.c. The code really is interleaved. >>> >>> I'll propose fixes for those two bugs by COB tomorrow, at the latest. >>> I'd *really* like to get all the open bugs fixed before we bump the >>> version. What do you think ? >> >> I think that depends on if PSARC is needed. If it's needed, I'll suggest >> we commit the new feature after ptop1.2 release. > > We don't need to file a case for this. It's a feature of the app, not a > new interface.
Hi Aubrey Do you have any more comments for these RFEs ? Thanks, Rafael
