Bill Holler wrote: > > Hi, > > The other usage of AcpiEvaluateObject() in cpu-acpi.c are > cpu_acpi_write_pdc() and cpu_acpi_cache_present_capabilities(). > Do we need to use the Typed version to evaluate the _PSC, _PPC > and _TPC objects? I'd suggest so. Any time we *know* what object we expect to be returned, we should use AcpiEvaluateObjectTyped(). I need to enforce that in code reviews, too :-) It simplifies the calling code, since it need only check for AE_OK return.
> > Thank you, > Bill > > >>> On 03/19/09 17:41, Li, Aubrey wrote: >>>> ... >>>> This is not a problem. I saw a bunch of boxes implementing the >>>> processor >>>> related objects like this way. As long as _PDC is evaluated with >>>> the right >>>> parameter, _CST should be loaded properly. >>>> >>> >>> >> > > _______________________________________________ > tesla-dev mailing list > tesla-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/tesla-dev
