http://defect.opensolaris.org/bz/show_bug.cgi?id=7951
Summary: display.c needs some lovin'
Classification: Development
Product: power-mgmt
Version: unspecified
Platform: ANY/Generic
OS/Version: OpenSolaris
Status: ACCEPTED
Severity: normal
Priority: P3
Component: powertop
AssignedTo: rafael.vanoni at sun.com
ReportedBy: rafael.vanoni at sun.com
CC: tesla-dev at opensolaris.org
There are a few things in display.c that need fixing:
(1) PowerTOP's use of the curses library is a bit sloppy, the windows are all
destroyed and recreated at each iteration of the main program loop.
(2) the status bar has ten slots pre-allocated, each capable of holding 40
characters. Which is completely unnecessary since the status bar window is a
single line subwindow.
(2 1/5) there's no routine to add/remove slots from the status bar, messages
are simply copied to a slot, with no variable indicating how the slots are
being used
(3) the title window is destroyed and recreated at each iteration, even though
it's content is static throughout the execution of the application
(4) the routine that displays the title window also displays the status bar,
each at extreme opposites of each other, one with static and the other with
dynamic content
(5) the p-state subwindow will display %NaN values when such information is not
available (usually because of a DTrace error), result of a division by zero.
--
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
