Rafael.Vanoni wrote:

> webrev @ http://cr.opensolaris.org/~rafaelv/ptop-freq/
> 
> Let me know what you think.
> 
> Thanks,
> Rafael

comments below:

1) we have a macro HZ2MHZ(speed), use it instead of
speed /= 1000000.

2) Please take a look at the patch I posted, time_accounted
should be reset to ZERO if dt_state_time < cpu_pow->time_accounted.

3) As for the loop,
for (i = 0; i < g_npstates; i++) {
                         if (g_pstate_info[i].speed == speed) {
                break;
                }
}
I believe we should jump out once we get one match to save the time.

Thanks,
-Aubrey

Reply via email to