On Thu, Sep 18, 2008 at 2:32 AM, Chad Mynhier <cmynhier at gmail.com> wrote: > On Wed, Sep 17, 2008 at 2:16 PM, Chad Mynhier <cmynhier at gmail.com> wrote: >> On Wed, Sep 17, 2008 at 1:37 PM, Rafael Vanoni <Rafael.Vanoni at sun.com> >> wrote: >>> >>> Hey Chad, it looks good. >>> >>> Aubrey, can you confirm the fix so Chad can push the changes? >>> >>> Chad, send me your OS id and please file a bug against this in >>> defect.opensolaris.org. >> >> My ID is OS0124. >> >> I've opened a bug for this: >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3468. > > BTW, I've made a minor update to the webrev (removing an unused variable.) > > http://cr.opensolaris.org/~cmynhier/powertop/ >
Thanks for the patch, :-) sorry if I didn't read the latest code, all the collection could be successful and "reinit" will be used without initialization. right? Others look good. I didn't dig into the dtrace problem, just wonder is this expected? Or Is the patch just a workaround temporarily and dtrace problem will be fixed eventually? Thanks, -Aubrey
