On Fri, 19 Sep 2008, Terry (Sarito) Whatley wrote:
> Bill Holler wrote:
> > Hi Tesla-dev,
> >
> > Here is a proposed PSARC self review. Please send
> > feedback. We plan to submit this as soon as possible.
> > All of its content has already been discussed here.
> >
> > I filled out most all of the onepager template. Please
> > let me know if this should be cut down to a smaller
> > subset.
> >
> > Thank you,
> > Bill
> >
> >
>
> Sorry to be a pain, but I disagree that this qualifies for self
> review. For self-review, IIRC, it needs to not introduce any new
> interfaces, which this does. This should be a fast-track.
ARC review is all about adding, changing, and removing interfaces,
so if adding interfaces didn't qualify, then there wouldn't be a lot
of value to self review.
Self-review (a.k.a. closed approved automatic) qualifies if the
submission is small, straight forward, and easily understood by just
about any reader. It also comes with the option to turn it into a
regular fasttrack if anyone objects to the self-review request.
I believe it qualifies and will be submitted as such (after all,
PowerTOP was accepted as a self-review). Anyone is welcome to
subscribe to psarc-ext, and request regular fasttrack status.
> I think you need to list the new keyword as an exported interface.
> Do you plan to populate power.conf with this keyword, or only to support it if
> it shows up.
> I strongly recommend the latter.
> Is there any plan to support setting this any other way besides editing
> power.conf?
I also have comments (to follow) that requests format change and
updated text, and these three items should be in the spec.
> This case is another argument for having the PM umbrella case.
Are you volunteering to do the umbrella case?
>
> thanks,
> sarito
Cheers!
---- Randy
