On 10/07/08 17:42, Li, Aubrey wrote: > Bart Smaalders wrote: > > >> Mark Haywood wrote: >> >>> However, I should note that it is beneficial to know when these >>> objects (_PSS, _TSS, _CSS) are not found. When users come back and >>> ask why SpeedStep isn't supported or (throttling or C-state >>> support), it is nice to easily find out that the objects aren't >>> being provided by ACPI. Maybe we should add dtrace probes at these >>> points instead of log messages? >>> >> You could print: >> >> Oct 5 18:11:30 sol cpudrv: [ID 569748 kern.info] NOTICE: cpu_acpi: >> SpeedStep/Throttling/Deep C states not supported on this CPU. >> >> as appropriate... >> > > Actually we have several ways to check if these states are supported or not. > So a message like above can't do any help. The current log message can > help us to know why these states are not supported. But meanswhile, it scares > the users. IMHO, we should keep these log messages, otherwise it's hard to > figure out why these states are not supported on a user's machine. What we > can change is removing the "error" word and use "notice" or else instead. > > What do you think? > > Thanks, > -Aubrey > _______________________________________________ > tesla-dev mailing list > tesla-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/tesla-dev >
How about something like: Oct 5 18:11:30 sol cpudrv: [ID 569748 kern.info] NOTICE: cpu_acpi: no ACPI _TSS. SpeedStep/Throttling/Deep C states not supported on this platform. Printing both the cause and effect may be less scary to customers than just printing the cause with no explanation? Regards, Bill
