Hi Bill, Bill Holler wrote:
> Hi Tesla dev, > > Here is the patch for /etc/power.conf cpu_deep_idle setting > and Suspend/Resume. This will be pushed into pad-gate > tomorrow after more testing and possible refactoring. > > This uses a callback for S/R. It was pointed out that the > DDI_SUSPEND/DDI_RESUME cpudrv_attach/cpudrv_detach > entry points in common cpudrv are only there to support the > legacy pm framework. The x86 cpudrv driver is moving > away from that framework which motivated this patch to use callbacks > instead. > > The callback in cpudrv is in the CPU-specific cpu_idle "module". > This allows different CPU support code to perform different > S/R and enable/disable functionality. > Another option was placing the callbacks in cpudrv_mach and > adding supporting methods into cpudrv_cstate_ops_t. > > This uses the 2-stage idle function pointers as Eric suggested. > That could be removed if we used checks in cpu_acpi_idle() > for initialized cpus, or used per cpu idle function pointers. > The patch looks great. Currently, the default c-state setting is enabled, is it intended? is it time to rename "cpupm" to something else? This word looks including cpu deep idle setting but actually not. Thanks, -Aubrey
