Rafael Vanoni wrote:

> Here's a patch to move the definition of global variables from
> powertop.h to powertop.c and leave the ones in the header as externs.
> 
> This also adds a "g_" prefix to all of these global variables and
> removes 5/6 that weren't being used. The prefix is helpful given the
> number of global vars we need to keep around.
> 
> It's a large file, but an easy one to go through ;)
> Please let me know what you think.
> 
> Thanks,
> Rafael

The patch looks good, our coding style becomes much better,
Thanks for the great work, :)

-Aubrey

Reply via email to