http://defect.opensolaris.org/bz/show_bug.cgi?id=6416
Summary: Some cpu_acpi_cache_cst() messages could be more
descriptive
Classification: Development
Product: power-mgmt
Version: unspecified
Platform: Other
OS/Version: Solaris
Status: NEW
Severity: minor
Priority: P4
Component: c-state
AssignedTo: bill.holler at sun.com
ReportedBy: bill.holler at sun.com
CC: tesla-dev at opensolaris.org
One of the test machines only had 1 _CST cstate Element.
It was not possible from the /var/adm/messages output to determine
why the kernel failed to get valid cstate elements from the _CST object.
Changing some cmn_err() messages will really help support.
Proposed changes.
bash-3.2$ hg pdiffs usr/src/uts/i86pc/os/cpupm/cpu_acpi.c
Enter passphrase for key '/home/bholler/.ssh/id_dsa':
diff -r 6eed2c62d463 usr/src/uts/i86pc/os/cpupm/cpu_acpi.c
--- a/usr/src/uts/i86pc/os/cpupm/cpu_acpi.c Mon Feb 02 13:50:29 2009 -0800
+++ b/usr/src/uts/i86pc/os/cpupm/cpu_acpi.c Thu Feb 05 15:47:11 2009 -0800
@@ -651,10 +651,14 @@
*/
cnt = obj->Package.Elements[0].Integer.Value;
if (cnt < 1 || cnt != obj->Package.Count - 1) {
- cmn_err(CE_NOTE, "!cpu_acpi: _CST is not valid\n");
+ cmn_err(CE_NOTE, "!cpu_acpi: _CST invalid element count %d != "
+ "Package count %d\n",
+ (int)cnt, (int)obj->Package.Count - 1);
AcpiOsFree(abuf.Pointer);
return (-1);
}
+ cmn_err(CE_NOTE, "!cpu_acpi: _CST cnt %d; Package.Count %d\n",
+ (int)cnt, (int)obj->Package.Count - 1);
CPU_ACPI_CSTATES_COUNT(handle) = (uint32_t)cnt;
CPU_ACPI_CSTATES(handle) = kmem_zalloc(CPU_ACPI_CSTATES_SIZE(cnt),
@@ -708,7 +712,8 @@
}
if (count < 2) {
- cmn_err(CE_NOTE, "!cpu_acpi: _CST is not valid\n");
+ cmn_err(CE_NOTE, "!cpu_acpi: _CST invalid count %d < 2\n",
+ count);
AcpiOsFree(abuf.Pointer);
return (-1);
}
--
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
