http://defect.opensolaris.org/bz/show_bug.cgi?id=6534
Aubrey.Li <aubrey.li at intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aubrey.li at intel.com
Status|NEW |ACCEPTED
--- Comment #1 from Aubrey.Li <aubrey.li at intel.com> 2009-02-10 23:30:44 ---
(In reply to comment #0)
> hpet_acpi.h:
> Still misspelling femto as "FEMPTO" in a number of places.
done
> Line 224 "LACPI" should be "LAPIC"
done
> Line 252: Is 10 "enough" ?
> Line 253: Why "3"?
====>TBD
> Non-capitalizations of "hpet"
done
> hpet.h:
> Line 68: What is "unix.so" ?
done
> cpupm_mach.h:
> Change multiple occurrences of "it's" to "its" (i.e. "some of it's
> processors")
done
> mp_machdep.c:
> Remove "XXX"'ed statement from hpet definition
done
> What's up with the XXX DTRACE_PROBE1 didn't work stuff?
This problem is gone after cpupm is moved from cpudrv to the core.
Comments is changed. done
> /power saving/power-saving/
done.
> wtf is XXX_highbit() ? :)
====>TBD
> cpupm_throttle.c:
> /power manage/power-manage/
done
> cpupm_mach.c:
> s/%90/90%/
done
> What about the XXX @ mcpu c-state?
Can be safely removed, done
> XXX @ PAD-specific interfaces?
can be safely removed
> s/book keeping/bookkeeping/
done
> s/Often wakeup/Wakeup often/ ?
done
> cpu_idle.c:
> s/See if there's any other/See if there are any other/
done
> (plus other instances of "there's" -> "there are")
done
> s/trys/tries/
done
> asymmetric usage of "lAPIC" and "LAPIC" -- please pick one :)
LAPIC is picked, done
> Lines 350,392: If it's dead, remove it.
done
> Line 498: s/Today all Intel's processor/Today, all Intel processors/
done
> ...and... s/C3 share cache/C3 shared cache/
done
> Line 803: was a final decision made here?
====>TBD
> Line 836 s/for it/for them/
done
> cpu_acpi.c:
> Garbled statement:
> + * if there have duplicate entries, we keep the
> "If there are duplicate entries" maybe ?
> + * last one. This fixes:
> + * 1) some buggy BIOS has total duplicate entries.
> "Some buggy BIOSes have"...
> + * we got a valid entry, count it up
> Please rephrase "count it up"
done
> apic_regops.c:
> This should no longer be necessary. (the line of code above the line you
> added is the fix!)
====>TBD, What is not necessary?
> apic.c:
> s/Set timer far into future/Set timer far into the future/
> uncapitalize "Current Count" & no space between nano and seconds.
done
> hpet_acpi.c:
> Again, lAPIC & LAPIC -- pick one :) .
LAPIC is picked, done
> You can use "IOAPIC" instead of "I/O APIC" :)
done
> s/possibly shared/possibly-shared/
done
> Isn't the plural of proxy "proxies" ?
done
> s/possibly stuck/possibly-stuck/
done
> hpet_checksum_table : do we REALLY not have another 8-bit checksum routine
> elsewhere in the kernel that you can use instead of creating another one? :)
not found.
> "Guaranty" is misspelled all over the place. It's "Guarantee".
done
> s/written to/written-to/
done
> s/states main counter/states that the main counter/
done
> This comment needs a re-write:
> 633 * The I/O APIC line (vector) is programmed in ioapic_init_intr() called
> 634 * from apic_picinit() psm_ops apic_ops entry point after we return from
> 635 * apic_init() psm_ops entry point.
====>TBD
> s/irq/IRQ/ -- capitalization varies -- please be consistent.
done
> 934 * The order of these opperations is important to avoid
> it's "operations"
done
> Is it really OK to try to grab a lock with interrupts disabled?
> 941 cli();
> 942 while (!mutex_tryenter(&hpet_proxy_lock)) {
we are safe with mutex_tryenter(), the lock became the spinlock.
> hpet_isr() clears interrupts directly (instead of saving the flags and
> restoring them on exit) -- I hope this doesn't cause problems in the future.
====>TBD
> s/level triggered/level-triggered/
done
> 1053 * Returns B_FLASE if the HPET could not be programmed to interrupt
> before
> "B_FALSE"
done
> Please restate this:
> 1092 * There are no CPUs to program the HPET for.
> DJ Jazzy HPET and the Fresh Prince?:
> 1094 * Letting the HPET timer rap around to the
> current
> 1177 * A critical section exists between when the HPET is programed
> "programmed"
> 1280 * Do not enable a LAPIC Timer than was initially disabled.
> "that was initially disabled"
====>TBD
> 1311 #include <sys/clock.h>
> EWW. Please put this at the top of the file with the other #includes.
done
--
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
