Rafael Vanoni Polanczyk wrote: > Aubrey Li wrote: >> 2008/6/23 Rafael Vanoni <Rafael.Vanoni at sun.com>: >>> Forgot to zero cstate_info[i].events, here's the correct diff. >>> >> Thanks for the great work, :-) >> This one looks good except this: >> >> -static char cpupm_treshold[] = " echo cpu-threshold 1s >> >> /etc/power.conf"; +static char cpupm_treshold[] = " echo >> cpu-threshold 5s >> /etc/power.conf"; >> >> why do we need this change? >> > > Sorry I didn't comment this one before. 1s seems a bit too little, > don't you think? I can't remember the default, tho. > > thanks > rafael
Not really, intel processor can switch very quickly (in microseconds). That's why we are working on the subsecond p-state. So here, we should set this threshold as small as possible, 1s is the right value. Thanks, -Aubrey
