Rafael.Vanoni wrote:
> Li, Aubrey wrote:
>> Rafael Vanoni wrote:
>>
>>> Here's a patch fixing return values for the dtrace side of PowerTOP
>>> plus an all around header cleanup.
>>>
>>> thanks
>>> Rafael
>> ========================================================
>> diff -r 9b1c31702fc2 usr/src/cmd/powertop/cpufreq.c
>> --- a/usr/src/cmd/powertop/cpufreq.c Tue Jul 15 10:09:25 2008 +0100
>> +++ b/usr/src/cmd/powertop/cpufreq.c Tue Jul 15 12:13:57 2008 +0100
>> @@ -148,35 +147,35 @@ * Setup DTrace to look for CPU frequency
>> changes */ if ((g_dtp = dtrace_open(DTRACE_VERSION, 0,
&err))
>> == NULL) { - pt_error("cannot open dtrace library: %s\n",
>> + pt_error("cpufreq.c : cannot open dtrace library: %s\n",
>> dtrace_errmsg(NULL, err));
>> - return (-1);
>> + return (-2);
>> }
>> ========================================================
>> why use (-2) to return here?
>>
>
> Just to differentiate from
>
> /*
> * Return if speed transition is not supported
> */
> if (npstates < 2)
> return (-1);
>
> in case we need/decide to use the return value later on.
>
okay, please commit
Thanks,
-Aubrey
