Hi Eric, Eric Saxe wrote:
> Hey Aubrey, > > Please take a look at the following change. It fixes an issue with CPU > enumeration on SPARC, and also makes the command better able > to support > c-states greater than 1. :) > > http://cr.opensolaris.org/~esaxe/pt_bugfix > > This webrev doesn't reflect your most recent patch that caps the time > spent in c1 (webrev generated prior to merging with your two > most recent > commits)...however these changes may obviate the need for that...since > with these changes that cap is imposed in do_cpuidle_stats(). > > What do you think? > > Thanks, > -Eric The patch looks very good. We should consider the offline CPU. Does it fix the bug [c-state] statistics seem a bit off? If so, please revert my fix but be based on the suggestion patch. Thanks, -Aubrey
