Please make PR for master (4.0) branch and I will cherry-pick for 3.05... Zdenko
ut 5. 6. 2018 o 4:38 Paul Kitchen <[email protected]> napísal(a): > ZDenko, > > I checked out the latest tesseract code and updated to branch 3.05. I see > that the int64_t area bug is already fixed (thanks!). I also see that the > buffer read overrun is partially fixed. There is this line > in ReadAllBoxes(): > > box_data.push_back('\0'); > > Since the memory will have to be deleted and reallocated, this will be > quite inefficient. That is why I added this line to LoadDataFromFile(): > > data->reserve(size + 1); > > I'm willing to make the change in a feature branch then create the pull > request. I tried to create a branch in github but apparently I don't have > branch creation privilege. I thought about forking but I'm not familiar > with how that works, or if it would even be appropriate. Can you either > make the change yourself or grant me branch creation privilege in the repo > so I can make the change in a branch then create a pull request? > > By the way, I checked out master branch and it also has the same problem > in LoadDataFromFile(). > > -- > You received this message because you are subscribed to the Google Groups > "tesseract-ocr" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/tesseract-ocr. > To view this discussion on the web visit > https://groups.google.com/d/msgid/tesseract-ocr/307a7e38-bb5d-4870-ac12-29c735c3c9f8%40googlegroups.com > <https://groups.google.com/d/msgid/tesseract-ocr/307a7e38-bb5d-4870-ac12-29c735c3c9f8%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "tesseract-ocr" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/tesseract-ocr. To view this discussion on the web visit https://groups.google.com/d/msgid/tesseract-ocr/CAJbzG8xmWtEb3Rv0yWTdWBcrtSmFbtzhWn7mbx5y%3DGtjg1E%3DxA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
