cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

[stas]

stas        02/01/31 04:48:57

  Modified:    perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm
  Log:
  1. while processing __DATA__ sections in tests files, if by mistake (or
  by design) a single directive is passed  $rest is undef, and if pushed to
  @args as is, we get:
    Attempt to free unreferenced scalar at
    ../Apache-Test/lib/Apache/TestRun.pm line 567.
  when processed by set_handler, so the configuration silently fails. so we
  make sure that it's not undef.
  2. set_handler derefs $args which can be undef, so we init it to () in
  configure_pm_tests
  sub
  
  Revision  Changes    Path
  1.46      +2 -1      
httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigPerl.pm
  
  Index: TestConfigPerl.pm
  ===================================================================
  RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigPerl.pm,v
  retrieving revision 1.45
  retrieving revision 1.46
  diff -u -r1.45 -r1.46
  --- TestConfigPerl.pm 21 Jan 2002 02:13:55 -0000      1.45
  +++ TestConfigPerl.pm 31 Jan 2002 12:48:57 -0000      1.46
  @@ -206,6 +206,7 @@
               next;
           }
           my($directive, $rest) = split /\s+/, $_, 2;
  +        $rest = '' unless defined $rest;
           if ($outside_container{$directive}) {
               $self->postamble($directive => $rest);
           }
  @@ -278,7 +279,7 @@
   
           finddepth(sub {
               return unless /\.pm$/;
  -            my @args;
  +            my @args = ();
   
               my $pm = $_;
               my $file = catfile $File::Find::dir, $pm;