On Tue, 28 Aug 2001, Doug MacEachern wrote:

> On Tue, 28 Aug 2001, Gary Benson wrote:
>
> > The tests for mod_access fail if 127.0.0.1 does not resolve as "localhost"
> > (mine resolves as "localhost.localdomain"). This patch fixes it.
>
> excellent!  however, your patch did not apply for me, maybe you needed to
> cvs up first?  the first two hunks applied with offset, so that would seem
> to be the case.
> i added your code to determine localhost to Apache::TestConfig, so you can
> say:
>
> my $localhost_name = Apache::TestConfig->default_localhost;
>
> if you could resubmit against the current version using that method, that
> would be great.  thanks.

Is "my $localhost_name = Apache::TestConfig->default_localhost;" valid?
Should you not do this:

    my $env = Apache::TestConfig->thaw;
    my $localhost_name = $env->{vars}->{servername};

instead?

Gary

[ Gary Benson, Red Hat Europe ][ [EMAIL PROTECTED] ][ GnuPG 60E8793A ]

Reply via email to