Doug MacEachern wrote:

On Thu, 8 Nov 2001, Stas Bekman wrote:

patch doesn't apply for me, but looks good so just commit and ..


done


+    my @reasons = ();
     for (@modules) {
+        my $reason;
         if (/^[a-z0-9_]+$/) {


not sure if your mail has munged the patch, but indentation looks off like this everywhere.


I've moved to mozilla-mail recently, as it supports offline email with imap. Unfortunately it doesn't seem to handle properly inlined copy-n-paste :( yet


+   skip_unless(sub { $perlpod }, "dir $perlpod doesn't exist");


'$perlpod' should be '$vars->{perlpod}' in the reason string, since $perlpod is undef if the dir doesn't exist.

oops, fixed. thanks


_____________________________________________________________________ Stas Bekman JAm_pH -- Just Another mod_perl Hacker http://stason.org/ mod_perl Guide http://perl.apache.org/guide mailto:[EMAIL PROTECTED] http://ticketmaster.com http://apacheweek.com http://singlesheaven.com http://perl.apache.org http://perlmonth.com/



Reply via email to