Geoffrey Young wrote:

looks good, but what happens when 1.3 is used? Shouldn't it always return preforked?


doh!

here's a better patch.

Well, I'm not sure if that's the right thing to do. I was just asking what should be done in the 1.3 case? If you require a specific mpm, shouldn't that imply that you require apache 2.0? i.e.:


plan ..., have_apache2 && have_apache_mpm('prefork');

what others think?

Index: TestConfigParse.pm
===================================================================
RCS file: 
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigParse.pm,v
retrieving revision 1.33
diff -u -r1.33 TestConfigParse.pm
--- TestConfigParse.pm  27 Apr 2003 22:52:28 -0000      1.33
+++ TestConfigParse.pm  30 Jun 2003 13:46:36 -0000
@@ -309,6 +309,10 @@
     if (my $mpm_dir = $self->{httpd_defines}->{APACHE_MPM_DIR}) {
         $self->{mpm} = basename $mpm_dir;
     }
+    else {
+        # Apache 1.3
+        $self->{mpm} = 'prefork';
+    }


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com



Reply via email to