on 7/10/03 18:00, Stas Bekman at [EMAIL PROTECTED] wrote:
Does this work?
else if ($redir) { $RedirectOK = $redir; }
It does. However, isn't this the same condition as in the top if clause? Wouldn't you want to:
Index: Apache-Test/lib/Apache/TestRequest.pm
===================================================================
RCS file: /home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRequest
.pm,v
retrieving revision 1.81
diff -u -r1.81 TestRequest.pm
--- Apache-Test/lib/Apache/TestRequest.pm 8 Jul 2003 07:56:24 -0000
1.81
+++ Apache-Test/lib/Apache/TestRequest.pm 11 Jul 2003 04:28:45 -0000
@@ -88,14 +88,12 @@
$UA = undef;
}
- if (my $redir = $args->{requests_redirectable}) {
+ if (defined (my $redir = $args->{requests_redirectable})) {
if (ref $redir and (@$redir > 1 or $redir->[0] ne 'POST')) {
$RedirectOK = 1;
} else {
$RedirectOK = 0;
}
- } else {
- $RedirectOK = $redir;
}
$args->{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};
In other words, if $redir is defined, do something with it to the effect of
$RedirectOK. If it isn't defined, go with the default value which is 1.
Looks right to me. I was just looking at the diff that you've posted earlier hence the awkward fixup suggestion. You probably don't even need defined. I'll let David decide how he wants it.
What exactly is this code trying to do?
David Wheeler was trying to make $RedirectOK to be a non-global flag, so you can change it locally to your specific test. He will soonish reply confirming whether this still works for him or not. I don't have the test suite that he has, so I can't test.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
