Re: new one: rwrite on aix with 1.3

[Stas Bekman]

Stas Bekman wrote:
Rodent of Unusual Size wrote:
-bI:/home/coar/web/server/libexec/httpd.exp -lc -o mod_test_rwrite.so
mod_test_rwrite.o
ld: 0711-244 ERROR: No csects or exported symbols have been saved.
apxs:Break: Command failed with rc=8
make: 1254-004 The error code from the last command is 1.
the options are correct, but the module isn't being created properly.
It seems that it has been written this way on purpose:
c-modules/Makefile:
...
test_rwrite/.libs/mod_test_rwrite.so: test_rwrite/mod_test_rwrite.c
        -cd test_rwrite && $(MAKE) .libs/mod_test_rwrite.so
the leading '-' tells make to ignore any errors. removing it makes the error 
fatal. And we also lacked a check for the c-modules total make status.

The patch below fixes that. But I haven't written that code, so I don't know 
why it was written to specifically ignore any failures. So I'm hesitant to 
commit it.

Index: lib/Apache/TestConfigC.pm
===================================================================
RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigC.pm,v
retrieving revision 1.24
diff -u -r1.24 TestConfigC.pm
--- lib/Apache/TestConfigC.pm	8 Jan 2004 17:15:37 -0000	1.24
+++ lib/Apache/TestConfigC.pm	1 Mar 2004 21:02:24 -0000
@@ -123,13 +123,13 @@

     for my $dir (@dirs) {
         for my $targ (@targets) {
-            print $fh "$dir-$targ:\n\t-cd $dir && \$(MAKE) $targ\n\n";
+            print $fh "$dir-$targ:\n\tcd $dir && \$(MAKE) $targ\n\n";
         }
         my $lib = $self->cmodules_build_so($dir);
         my $cfile = "$dir/mod_$dir.c";
         push @libs, "$dir/$lib";
-        print $fh "$libs[-1]: $cfile\n\t-cd $dir && \$(MAKE) $lib\n\n";
+        print $fh "$libs[-1]: $cfile\n\tcd $dir && \$(MAKE) $lib\n\n";
     }
     for my $targ (@targets) {
@@ -211,6 +211,10 @@
     my $cmd = "cd $self->{cmodules_dir} && $Config{make} $targ";
     debug $cmd;
     system $cmd;
+    if ($?) {
+        die "Failed to build c-modules";
+    }
+
 }
 sub cmodules_compile {

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com