Re: [Patch] Better IPv6 detection and configuration

[Philippe M. Chiasson]

On Tue, 2004-03-30 at 12:11 -0800, Philippe M. Chiasson wrote:
> On Tue, 2004-03-30 at 09:04 +0100, Joe Orton wrote:
> > Would it not be simpler to just change the Listen statements to be
> > 
> > "Listen 0.0.0.0:port" by default and avoid the IPv6 issue entirely?
> 
> Well, this patch was trying to be somewhat smart about IPv6, but if
> people feel it's adequate to listen to 0.0.0.0 (ipv4 catch-all) by
> default all the time, it would work.
> 
> Thanks Joe, I somehow completely forgot 0.0.0.0 and stuck with '*'
> instead, and that was not what I wanted.

Something like this will most likely work for everyone (ipv4/v6) with
the only difference is that the test servers are not listening to
localhost anymore and could be reached from oustide machines (do we
care?)

Index: Apache-Test/lib/Apache/TestConfig.pm
===================================================================
RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.213
diff -u -I$Id -r1.213 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm        4 Mar 2004 05:51:31 -0000       
1.213
+++ Apache-Test/lib/Apache/TestConfig.pm        30 Mar 2004 20:19:41 -0000
@@ -1017,7 +1017,7 @@
     my @out_config = ();
     if ($self->{vhosts}->{$module}->{namebased} < 2) {
         #extra config that should go *outside* the <VirtualHost ...>
-        @out_config = ([Listen => $vars->{servername} . ':' . $port]);
+        @out_config = ([Listen => '0.0.0.0:' . $port]);
 
         if ($self->{vhosts}->{$module}->{namebased}) {
             push @out_config => [NameVirtualHost => "*:$port"];
@@ -1785,7 +1785,7 @@
 
 
 __DATA__
-Listen     @ServerName@:@Port@
+Listen     0.0.0.0:@Port@
 
 ServerRoot   "@ServerRoot@"
 DocumentRoot "@DocumentRoot@"
Index: Apache-Test/lib/Apache/TestConfigPerl.pm
===================================================================
RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigPerl.pm,v
retrieving revision 1.85
diff -u -I$Id -r1.85 TestConfigPerl.pm
--- Apache-Test/lib/Apache/TestConfigPerl.pm    16 Mar 2004 03:10:32 -0000      
1.85
+++ Apache-Test/lib/Apache/TestConfigPerl.pm    30 Mar 2004 20:19:41 -0000
@@ -222,7 +222,7 @@
     my($self, $module, $args) = @_;
     my $port = $self->new_vhost($module);
     my $vars = $self->{vars};
-    $self->postamble(Listen => $vars->{servername} . ':' . $port);
+    $self->postamble(Listen => '0.0.0.0:' . $port);
 }
 
 my %add_hook_config = (


> > joe

signature.asc
Description: This is a digitally signed message part