Re: make test problem underA-T

[Christopher H. Laco]

Geoffrey Young wrote:

Unless there's some reason that TestMM is deliberatly ignoring the

test=>TESTS option,

none that I can think of

I'll patch it this evening and send that to the list.

excellent.

--Geoff

Hey, why wait until I get home. See attached patch: TestMM.pm.patch.





-=Chris

--- TestMM.pm.orig	Wed Mar 30 14:48:16 2005
+++ TestMM.pm	Mon Sep 26 11:02:31 2005
@@ -50,8 +50,9 @@
 }
 
 sub test {
-
+    my $self = shift;
     my $env = Apache::TestConfig->passenv_makestr();
+    my $tests = 'TEST_FILES = ' . (exists $self->{'test'} ? $self->{'test'}->{'TESTS'} : '') . "\n";
 
     my $preamble = Apache::TestConfig::WIN32 ? "" : <<EOF;
 PASSENV = $env
@@ -80,9 +81,8 @@
 EOF
     }
 
-    return $preamble . <<'EOF' . $cover;
+    return $preamble . $tests . <<'EOF' . $cover;
 TEST_VERBOSE = 0
-TEST_FILES =
 
 test_clean :
 	$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \

All this patch does is toss {test=>TESTS} from Makefile.PL into the generated Makefile. In order to do that with the least amount of tweaking to test(), I've reverse TEST_FILES and TEST_VERBOSE variables in the output. No biggie. I'm not too thrilled with the code style, but test() isn't the most straight foward piece of code either. :-)

smime.p7s
Description: S/MIME Cryptographic Signature