On Sun, Nov 7, 2010 at 00:13, Gubinelli Massimiliano <[email protected]> wrote:
> 1) make the file chooser dialog native. At the moment this is disabled > since on the mac there is a difficulty: a native file open dialog do not > allow to type the file name. You have to take different actions in the case > of a file load or a file save and the old texmacs api didn't differentiate > the two possibilities. Now Joris has made some changes and when the dialog > has to be created we know if it is for a load or a save, so that in > principle we can choose the right native widget. Relevant lines in > Graphics/Gui/widget.hpp are > > widget file_chooser_widget (command cmd, string type, bool save); > // file chooser widget for files of a given 'type'; > // for files of type "image", the widget includes a previsualizer for > images > // 'save' indicates whether we intend to save the file > This looks easy enough, so let's say I tinker with this for a while. What "coding practices" should I adhere to? I can see how you like indentation, spacing and function layout, but: - Is it ok to create a new couple of files .hpp .cpp for every class? I like it that way, but I've seen that's not always the case in TM. - Is it ok if I correct indentation, style and typos as I review the code? Of course following your preferences, which I reckon are different from mine. - Is it ok to add comments to the classes and methods? It's a jungle in there and some markers might help others, if I get them right, that is. - In order to have meaningful updates to the repository, I'd have to prepare small patches. Do I send them to the list or to you? - How is localization implemented? À la QT or otherwise? Thanks, ________________ Miguel de Benito.
_______________________________________________ Texmacs-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/texmacs-dev
