Hi Thibaut Great work, I definitely like the approach.
As for refactoring, one of the things I want to do is have Riddle::Controller handle all the system calls for rake tasks, but it's pretty simple at the moment, and needs to allow for various options while remaining generic - as it's not TS, just Riddle. So, if you wanted to have a go at that, and shift system! into there, that'd be fantastic. I think checking the exit code is a good idea too - although will need to verify searchd and indexer don't do anything odd in that regard (pretty sure they won't). Cheers -- Pat On 07/02/2009, at 10:57 PM, Thibaut Barrère wrote: > > Hi, > > I commited a first patch to my fork designed to make it easier to > diagnose production issues (cron/passenger environments etc) when rake > ts:index / ts:start are called: > > * patch => > http://github.com/thbar/thinking-sphinx/commit/1fec8f7bb506cd4496c4b0b13fb0ccfa199b1b01 > * example output => http://gist.github.com/59911 > > This is a first pass to see if you would like to see this included > into TS. If you like it, I'm thinking about moving system! to some > module in Riddle and to patch further. I noticed a bunch of places > (including delta index) rely on `#{cmd}` which doesn't check the exit > code. > > I think it would be worthwhile to check the exit code there too - that > would avoid some headaches with passenger and cron delta indexing I > think -- but I'd love to have you opinion. Maybe this should be > configurable, I'm not sure yet. > > Pat, guys, what do you think ? > > cheers, > > -- Thibaut > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Thinking Sphinx" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/thinking-sphinx?hl=en -~----------~----~----~----~------~----~------~--~---
