Oh... so you're using a column called id as your Sphinx primary key,  
but object.id returns the hash?

-- 
Pat

On 31/07/2009, at 11:35 AM, Pierre Valade wrote:

>
> http://github.com/freelancing-god/thinking-sphinx/commit/b9fac6e0d19931629bc5757ddbbfbfc66dc3754f
>
> this commit breaks the set_sphinx_primary_key functionnality
>
> I think that attributes[klass.primary_key_for_sphinx.to_s] was the
> right way to find the primay_key id and not self.send
> (self.class.primary_key_for_sphinx) because A.R overwrite the :id
> method when you use :set_primary_key
>
> What do you think? I've changed this and this work just fine ;)
>
> Pierre
>
> On Jul 31, 10:27 am, Pierre Valade <[email protected]> wrote:
>> Great.
>> Thinking Sphinx is better everyday thanks to Pat and contributors.  
>> I'm
>> now using it in replacement of some mysql queries that were too
>> complex because they involve a lot of jointures.
>>
>> I'm now doing a "nil search" a lot of times !
>> Model.search nil, parameters
>>
>> And it's working great!
>>
>> On Jul 30, 8:26 pm, Jeffrey Chupp <[email protected]> wrote:
>>
>>> Thanks for merging it, Pat.
>>
>>> Pierre, I'll be happy to look into any issues you may discover. I'm
>>> not using some of the more complicated aspects of TS, so it isn't
>>> impossible that I've missed some of the more edge cases.
>>
>>> On Jul 30, 1:12 pm, Pierre Valade <[email protected]> wrote:
>>
>>>> Thanks Pat.
>>>> I've just updated my project with the last version.
>>>> I will let you know if there's any issues.
>>
>>>> Thanks!
>>
>>>> On Jul 30, 5:26 pm, Pat Allan <[email protected]> wrote:
>>
>>>>> Right, it's in and pushed. Let me know if there's any issues.
>>
>>>>> --  
>>>>> Pat
>>
>>>>> On 30/07/2009, at 2:43 PM, Pat Allan wrote:
>>
>>>>>> ... Or I could actually look at the git repo, and see there's  
>>>>>> recent
>>>>>> commits.
>>
>>>>>> --  
>>>>>> Pat
>>
>>>>>> On 30/07/2009, at 2:34 PM, Pat Allan wrote:
>>
>>>>>>> Hi Pierre
>>
>>>>>>> Seems plenty of people are asking for this, so I'll definitely  
>>>>>>> try to
>>>>>>> merge it in. Jeff: going by other emails, are you still using  
>>>>>>> your
>>>>>>> fork? Are you able to update it to my latest codebase?
>>
>>>>>>> Cheers
>>
>>>>>>> --  
>>>>>>> Pat
>>
>>>>>>> On 29/07/2009, at 9:45 AM, Pierre Valade wrote:
>>
>>>>>>>> Hi Pat,
>>
>>>>>>>> Would it be possible to merge the branch from semanticart which
>>>>>>>> allow
>>>>>>>> to specify a primary_key for sphinx.
>>>>>>>> http://github.com/semanticart/thinking-sphinx/commits/
>>>>>>>> alt_primary_key
>>
>>>>>>>> I find it useful because I have models with a uuid key (which  
>>>>>>>> is set
>>>>>>>> as the primary key for ActiveRecord).
>>
>>>>>>>> What do you think?
>>
>>>>>>>> Thanks,
>>
>>>>>>>> Pierre
> >


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Thinking Sphinx" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/thinking-sphinx?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to