Cool, thanks for the patch - any reason why you've changed the Index.name_for call back to Index.name?
-- Pat On 26/08/2009, at 7:22 AM, James Healy wrote: > > Pat Allan wrote: >> Hmm, there's specs in that test that attributes should be separated >> out, while printing a deprecation message. >> >> So, it *should* still work. Feel free to dive into the code to see >> why >> it isn't, or file a bug in the GitHub issues :) > > I tracked it down, and there's a fix here: > > http://github.com/yob/thinking-sphinx/commit/a3588c3c948dcfdcc0dc3e74910973f5096a2c7c > > The problem is I'm building my conditions hash like so: > > conditions = params.only(:title, :publisher, :created_at) > > So conditions is a HashWithIndifferentAccess, not a Hash, and the keys > are strings. TS 1.2.8 expects all the conditions keys to be symbols. A > somewhat valid assumption I'd say. > > In the interests of keeping behaviour unchanged until this feature is > removed completely, it would be great if the patch could be applied. > > It also changes the deprecation notice to print to logs instead of > STDOUT to increase its visibility. > > -- James Healy <jimmy-at-deefa-dot-com> Wed, 26 Aug 2009 16:15:13 > +1000 > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Thinking Sphinx" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/thinking-sphinx?hl=en -~----------~----~----~----~------~----~------~--~---
