Hi Brian You're right, my chained version really should return the original value - I'll patch that when I have the chance.
And sorry for the huge number of releases lately - that'll definitely slow down in the near future, as I've got some paid work to keep me busy instead ;) -- Pat On 15/12/2009, at 1:46 PM, Brian Percival wrote: > i'm looking at the following commit of after_commit: > 4dcaf2e79ea41f893664db70d1969dd90c568d82 > > one of the things it looks like it's doing (in after_commit/ > active_record.rb) is method-chaining establish_connection(), possibly > changing the return value of the original method (because if an > include is successful, it returns nil rather than what the original > establish_connection() method returned). i couldn't tell from the > rails documentation whether the return value is part of the > establish_connection() contract, but i was wondering if tossing the > original return value of the method is necessary/responsible. at the > least it is a little unexpected for an alias_method_chain to change > the return type, as they're supposed to be unobtrusive additions to > the original method (or so i thought). > > we've updated our code to no longer concat any method calls onto the > result of establish_connection(), but it took a while to figure out > what the heck was going on... ;) > > just recently upgraded to thinking sphinx 1.3.8 and then 1.3.9 (we > just can't keep up with all the mad releases happening lately!). > > thanks, > bp > > -- > > You received this message because you are subscribed to the Google Groups > "Thinking Sphinx" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/thinking-sphinx?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Thinking Sphinx" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/thinking-sphinx?hl=en.
