Hi Mark

I think I've fixed the deltas/facets combination bug - give 1.3.14 a try.

-- 
Pat

On 15/12/2009, at 8:32 PM, Mark Kocera wrote:

> Hi Pat,
> 
> Unfortunately 1.3.13 did not fix the problem in this application (it
> did fix deltas in a different app).
> 
> I did however find the culprit, it's this line in the define_index
> block:
> 
> indexes locality, :facet => true
> 
> After uncommenting this line, or removing the facet part, deltas work
> again. I tested this by adding facets to other fields as well. The
> behavior is consistent: without facets on fields, it all works fine,
> with facets, deltas stop working.
> 
> What's weird though, at least I think it's weird, for new objects, and
> objects still in the delta_index, this problem doesn't occur.
> 
> I'll try and debug this later in the week.
> 
> --
> Mark.
> 
> p.s. this is the whole define_index block:
> 
>  define_index do
>    indexes title, subtitle
>    indexes full_description, venue, street, postalcode
>    indexes locality, :facet => true
>    indexes organization(:name), :as => :organization
>    indexes province(:name), :as => :province
>    indexes kind(:name), :as => :kind
>    indexes tags(:name), :as => :tags
>    indexes subjects(:name), :as => :subjects
> 
>    has targets(:id), :as => :target_ids, :facet => true
>    has tags(:id), :as => :tag_ids, :facet => true
>    has subjects(:id), :as => :subject_ids, :facet => true
> 
>    has province_id, :facet => true
>    has kind_id, :facet => true
>    has organization_id, :facet => true
> 
>    has 'RADIANS(`events`.`lat`)', :as => :lat,  :type => :float
>    has 'RADIANS(`events`.`lng`)', :as => :lng,  :type => :float
> 
>    has days.day, :as => :days
> 
>    where "`events`.`archived` = 0"
>    where "`events`.`status` = 'approved'"
> 
>    set_property :field_weights => {
>      'title' => 100,
>      'subtitle' => 40,
>      'venue' => 30,
>      'organization' => 20,
>      'tags' => 5,
>      'subjects' => 5,
>      'full_description' => 1
>    }
> 
>    set_property :delta => :delayed
>    set_property :group_concat_max_len => 8192
>  end
> 
> 
> On Dec 15, 1:57 am, Pat Allan <[email protected]> wrote:
>> Hi Mark
>> 
>> Not-quite-consistent patching/testing on my part - I was able to reproduce 
>> this. 1.3.13 has a fix.
>> 
>> Thanks for the pointer on the deprecated code, too.
>> 
>> --
>> Pat
>> 
>> On 14/12/2009, at 8:18 PM, Mark Kocera wrote:
>> 
>> 
>> 
>>> Hi Pat,
>> 
>>> No problem. Thanks for your quick response!
>> 
>>> Everything works correctly now when adding a new object. And as long
>>> as objects are still in the delta index, jobs are added when the
>>> object is changed.
>> 
>>> But for objects already in the core index, of after a full index,
>>> delta jobs are'nt added when an object is changed (they should,
>>> right?). This could have something to do with my code, I'm still
>>> investigating.
>> 
>>> Is anybody else seeing this?
>> 
>>> BTW, ThinkingSphinx::Deltas::FlagAsDeletedJob#perform is calling
>>> deprecated method ThinkingSphinx::Search.search_for_id
>> 
>>> --
>>> Cheer, Mark.
>> 
>>> On Dec 14, 6:33 am, Pat Allan <[email protected]> wrote:
>>>> Hi Mark
>> 
>>>> Sorry about the continuing bugs, I managed to find the source of your 
>>>> problem (at least, I'm pretty sure it's the cause), and it's now fixed in 
>>>> 1.3.12, which I've just pushed to GitHub and Gemcutter.
>> 
>>>> --
>>>> Pat
>> 
>>>> On 14/12/2009, at 4:14 AM, Mark Kocera wrote:
>> 
>>>>> Hi,
>> 
>>>>> Unfortunately it seems 1.3.11 does not yet solve my delta problems.
>>>>> These are the relevant parts of the problematic model:
>> 
>>>>> class Event < ActiveRecord::Base
>> 
>>>>>  has_and_belongs_to_many :targets, :order => "name ASC"
>> 
>>>>>  has_one :image, :as => :attachable, :class_name =>
>>>>> 'Asset', :dependent => :destroy
>>>>>  accepts_nested_attributes_for :image
>> 
>>>>>  define_index do
>>>>>    indexes title
>> 
>>>>>    ...
>> 
>>>>>    has targets(:id), :as => :target_ids, :facet => true
>>>>>    has image(:id), :as => :image_id
>> 
>>>>>    set_property :delta => :delayed
>>>>>  end
>> 
>>>>> Jobs are added when these fields have values, but when they're empty,
>>>>> the jobs do not get added. (As expected, when I uncomment these lines
>>>>> jobs are added.)
>> 
>>>>> I think this should have been fixed in the 1.3.10 release? I'm not
>>>>> sure how to debug this.
>> 
>>>>> --
>>>>> Mark
>> 
>>> --
>> 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Thinking Sphinx" group.
>>> To post to this group, send email to [email protected].
>>> To unsubscribe from this group, send email to 
>>> [email protected].
>>> For more options, visit this group 
>>> athttp://groups.google.com/group/thinking-sphinx?hl=en.
> 
> --
> 
> You received this message because you are subscribed to the Google Groups 
> "Thinking Sphinx" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to 
> [email protected].
> For more options, visit this group at 
> http://groups.google.com/group/thinking-sphinx?hl=en.
> 
> 

--

You received this message because you are subscribed to the Google Groups 
"Thinking Sphinx" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/thinking-sphinx?hl=en.


Reply via email to