Hi Thomas

Sounds like a definite improvement for sure - I'll try to patch it at some 
point soon, but you're welcome to give it a shot yourself, if you'd like.

-- 
Pat

On 21/04/2012, at 1:45 AM, Thomas Fisher wrote:

> Hello,
> 
> I'm working with Thinking/Flying sphinx in production, and have
> encountered an issue. We're seeing a lot of connection reset errors
> from Sphinx, and investigating the problem, I found this method:
> 
> def updatable_attributes(index)
>  index.attributes.select { |attrib| attrib.updatable? }
> end
> 
> Sphinx is updating the attributes of a model every time it saves,
> regardless of whether or not the attributes have actually changed. I
> was wondering if there was a reason not to just do this instead
> (similar to what indexed_data_changed? does for the delta class):
> 
> def updatable_attributes(index)
>  index.attributes.select { |attrib| attrib.updatable? &&
> attrib.changed? }
> end
> 
> Any thoughts?
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Thinking Sphinx" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to 
> [email protected].
> For more options, visit this group at 
> http://groups.google.com/group/thinking-sphinx?hl=en.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"Thinking Sphinx" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/thinking-sphinx?hl=en.

Reply via email to