Author: dreiss
Date: Tue Jun 10 15:57:59 2008
New Revision: 666380
URL: http://svn.apache.org/viewvc?rev=666380&view=rev
Log:
Make signedness of integers explicit, and fix double read/write.
Also fix typo of i63 for i64
Modified:
incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl
Modified: incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl
URL:
http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl?rev=666380&r1=666379&r2=666380&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl (original)
+++ incubator/thrift/trunk/lib/alterl/src/thrift_binary_protocol.erl Tue Jun 10
15:57:59 2008
@@ -94,19 +94,19 @@
write(This, {bool, false}) -> write(This, {byte, 0});
write(This, {byte, Byte}) ->
- write(This, <<Byte:8/big>>);
+ write(This, <<Byte:8/big-signed>>);
write(This, {i16, I16}) ->
- write(This, <<I16:16/big>>);
+ write(This, <<I16:16/big-signed>>);
write(This, {i32, I32}) ->
- write(This, <<I32:32/big>>);
+ write(This, <<I32:32/big-signed>>);
-write(This, {i63, I64}) ->
- write(This, <<I64:64/big>>);
+write(This, {i64, I64}) ->
+ write(This, <<I64:64/big-signed>>);
write(This, {double, Double}) ->
- write(This, <<Double:64/big>>);
+ write(This, <<Double:64/big-signed-float>>);
write(This, {string, Str}) when is_list(Str) ->
write(This, {i32, length(Str)}),