svn commit: r926466 - /incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc

[bryanduxbury]

Author: bryanduxbury
Date: Tue Mar 23 05:39:18 2010
New Revision: 926466

URL: http://svn.apache.org/viewvc?rev=926466&view=rev
Log:
THRIFT-701. java:  Generated classes take up more space in jar than needed

Use a static {} block instead of an anonymous inner class to define 
metaDataMap. This saves some space in jars generated by avoiding the internal 
class.

Modified:
    incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc

Modified: incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc
URL: 
http://svn.apache.org/viewvc/incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc?rev=926466&r1=926465&r2=926466&view=diff
==============================================================================
--- incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc 
(original)
+++ incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc Tue 
Mar 23 05:39:18 2010
@@ -2007,14 +2007,17 @@ void t_java_generator::generate_java_met
   vector<t_field*>::const_iterator f_iter;
 
   // Static Map with fieldID -> FieldMetaData mappings
-  indent(out) << "public static final Map<_Fields, FieldMetaData> metaDataMap 
= Collections.unmodifiableMap(new EnumMap<_Fields, 
FieldMetaData>(_Fields.class) {{" << endl;
+  indent(out) << "public static final Map<_Fields, FieldMetaData> 
metaDataMap;" << endl;
+  indent(out) << "static {" << endl;
+  indent_up();
+
+  indent(out) << "Map<_Fields, FieldMetaData> tmpMap = new EnumMap<_Fields, 
FieldMetaData>(_Fields.class);" << endl;
 
   // Populate map
-  indent_up();
   for (f_iter = fields.begin(); f_iter != fields.end(); ++f_iter) {
     t_field* field = *f_iter;
     std::string field_name = field->get_name();
-    indent(out) << "put(_Fields." << constant_name(field_name) << ", new 
FieldMetaData(\"" << field_name << "\", ";
+    indent(out) << "tmpMap.put(_Fields." << constant_name(field_name) << ", 
new FieldMetaData(\"" << field_name << "\", ";
 
     // Set field requirement type (required, optional, etc.)
     if (field->get_req() == t_field::T_REQUIRED) {
@@ -2029,12 +2032,9 @@ void t_java_generator::generate_java_met
     generate_field_value_meta_data(out, field->get_type());
     out  << "));" << endl;
   }
-  indent_down();
-  indent(out) << "}});" << endl << endl;
 
-  // Static initializer to populate global class to struct metadata map
-  indent(out) << "static {" << endl;
-  indent_up();
+  indent(out) << "metaDataMap = Collections.unmodifiableMap(tmpMap);" << endl;
+
   indent(out) << "FieldMetaData.addStructMetaDataMap(" << type_name(tstruct) 
<< ".class, metaDataMap);" << endl;
   indent_down();
   indent(out) << "}" << endl << endl;