svn commit: r1025678 - /incubator/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSocket.java

[bryanduxbury]

Author: bryanduxbury
Date: Wed Oct 20 19:04:07 2010
New Revision: 1025678

URL: http://svn.apache.org/viewvc?rev=1025678&view=rev
Log:
THRIFT-959. java: TSocket seems to do its own buffering inefficiently

This patch removes the buffering from TSocket. This seems to improve 
performance marginally on small reads and writes that are buffered elsewhere 
(like the Framed Transport).

Modified:
    incubator/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSocket.java

Modified: 
incubator/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSocket.java
URL: 
http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSocket.java?rev=1025678&r1=1025677&r2=1025678&view=diff
==============================================================================
--- 
incubator/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSocket.java 
(original)
+++ 
incubator/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSocket.java 
Wed Oct 20 19:04:07 2010
@@ -19,16 +19,14 @@
 
 package org.apache.thrift.transport;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.io.BufferedInputStream;
-import java.io.BufferedOutputStream;
 import java.io.IOException;
 import java.net.InetSocketAddress;
 import java.net.Socket;
 import java.net.SocketException;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * Socket implementation of the TTransport interface. To be commented soon!
  *
@@ -74,8 +72,8 @@ public class TSocket extends TIOStreamTr
 
     if (isOpen()) {
       try {
-        inputStream_ = new BufferedInputStream(socket_.getInputStream(), 1024);
-        outputStream_ = new BufferedOutputStream(socket_.getOutputStream(), 
1024);
+        inputStream_ = socket_.getInputStream();
+        outputStream_ = socket_.getOutputStream();
       } catch (IOException iox) {
         close();
         throw new TTransportException(TTransportException.NOT_OPEN, iox);
@@ -178,8 +176,8 @@ public class TSocket extends TIOStreamTr
 
     try {
       socket_.connect(new InetSocketAddress(host_, port_), timeout_);
-      inputStream_ = new BufferedInputStream(socket_.getInputStream(), 1024);
-      outputStream_ = new BufferedOutputStream(socket_.getOutputStream(), 
1024);
+      inputStream_ = socket_.getInputStream();
+      outputStream_ = socket_.getOutputStream();
     } catch (IOException iox) {
       close();
       throw new TTransportException(TTransportException.NOT_OPEN, iox);