[
https://issues.apache.org/jira/browse/THRIFT-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597632#action_12597632
]
Bryan Duxbury commented on THRIFT-11:
-------------------------------------
I don't object to using the first patch, then.
Otherwise, does this look like something that should be committed to TRUNK?
> TThreadPoolServer won't shut down gracefully
> --------------------------------------------
>
> Key: THRIFT-11
> URL: https://issues.apache.org/jira/browse/THRIFT-11
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Attachments: graceful_shutdown-v2.patch, graceful_shutdown.patch
>
>
> The way I'm reading TThreadPoolServer.java, it looks like the stop() method's
> intent is to let the server shut down gracefully. However, because of the way
> that the WorkerProcess work loop is structured, if the clients are
> consistently making requests, the requests will keep getting served until the
> ThreadPoolExecutor's shutdown timeout expires, at which point the client
> threads will be forcibly aborted. This is because the innermost while loop
> around processor.process does not check the server's shutdown_ flag.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
