[
https://issues.apache.org/jira/browse/THRIFT-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601317#action_12601317
]
Ben Maurer commented on THRIFT-30:
----------------------------------
26 %if %{!?without_zlib: 1}
27 BuildRequires: zlib-devel
28 %endif
Without *zlib*. I think it's safe to make this always required.
22 %if %{!?without_libevent: 1}
23 BuildRequires: libevent-devel >= 1.2
24 %endif
25
Have you tested with the older version?
68 %{_libdir}/libthrift*.so*
69 %{_libdir}/pkgconfig/thrift*.pc
The .so symlinks and pc file should go into the devel package.
20 BuildRequires: boost-devel
Which version?
- I think you may need to add some more explicit dependencies for non-c things.
Eg, the python package should depend on python at runtime. The c++ devel
package probably needs to depend on all of the devel packages in BuildRequires.
Also, if I remember correcty, it's a best practice to have devel packages
depend on the exact version of the corresponding non-devel package. That way,
if you upgrade the non-devel package, the devel gets pulled in too.
> RPM .spec file for Thrift
> -------------------------
>
> Key: THRIFT-30
> URL: https://issues.apache.org/jira/browse/THRIFT-30
> Project: Thrift
> Issue Type: New Feature
> Reporter: David Reiss
> Assignee: David Reiss
>
> RPM .spec file, plus a few other small changes:
> http://thrift-git.thruhere.net/gitweb/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fc9;hb=dd0e19a
> Ben, can you review?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
