[
https://issues.apache.org/jira/browse/THRIFT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605025#action_12605025
]
Doug Cutting commented on THRIFT-37:
------------------------------------
Since you're not Paul, if you commit it, then one assumes you've read it and
think it is reasonable, which constitutes review. In general, if someone
besides the author of a patch commits it, that counts as review. Its best for
the wisdom of even no-brainer one-line patches to be confirmed by a second set
of eyes, and that's all that reviewing means. The best practice is simply not
to commit your own patches. That way everything is reviewed without a lot of
formal process. However this requires committers who are attentive and don't
ignore patches. Every patch proposed as ready-for-commit should either be -1'd
or committed within a few days.
> add some missing new lines to fprintfs
> --------------------------------------
>
> Key: THRIFT-37
> URL: https://issues.apache.org/jira/browse/THRIFT-37
> Project: Thrift
> Issue Type: Bug
> Reporter: Paul Saab
> Priority: Trivial
> Attachments: thrift.diff
>
>
> There are some fprintfs in TNonblockingServer that do not have new lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
