[ 
https://issues.apache.org/jira/browse/THRIFT-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury updated THRIFT-27:
--------------------------------

    Description: 
When generating code for the following structure:

{code}
struct ColumnDescriptor {
  1:Text name,
  2:i32 maxVersions = 3,
  3:string compression = "NONE",
  4:bool inMemory = 0,
  5:i32 maxValueLength = 2147483647,
  6:string bloomFilterType = "NONE",
  7:i32 bloomFilterVectorSize = 0,
  8:i32 bloomFilterNbHashes = 0
}
{code}

the generated record is:

{code}
-record(columnDescriptor, {name, maxVersions, compression, inMemory, 
maxValueLength, bloomFilterType, bloomFilterVectorSize, bloomFilterNbHashes}).
{code}

The generated record should have default values added.

  was:
When generating code for the following structure:

struct ColumnDescriptor {
  1:Text name,
  2:i32 maxVersions = 3,
  3:string compression = "NONE",
  4:bool inMemory = 0,
  5:i32 maxValueLength = 2147483647,
  6:string bloomFilterType = "NONE",
  7:i32 bloomFilterVectorSize = 0,
  8:i32 bloomFilterNbHashes = 0
}

the generated record is:

-record(columnDescriptor, {name, maxVersions, compression, inMemory, 
maxValueLength, bloomFilterType, bloomFilterVectorSize, bloomFilterNbHashes}).

The generated record should have default values added.


> Generated erlang types don't contain default values for records
> ---------------------------------------------------------------
>
>                 Key: THRIFT-27
>                 URL: https://issues.apache.org/jira/browse/THRIFT-27
>             Project: Thrift
>          Issue Type: Improvement
>         Environment: commit 289ec8413908ca2e5245641029b719909483adf5
>            Reporter: Todd Lipcon
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When generating code for the following structure:
> {code}
> struct ColumnDescriptor {
>   1:Text name,
>   2:i32 maxVersions = 3,
>   3:string compression = "NONE",
>   4:bool inMemory = 0,
>   5:i32 maxValueLength = 2147483647,
>   6:string bloomFilterType = "NONE",
>   7:i32 bloomFilterVectorSize = 0,
>   8:i32 bloomFilterNbHashes = 0
> }
> {code}
> the generated record is:
> {code}
> -record(columnDescriptor, {name, maxVersions, compression, inMemory, 
> maxValueLength, bloomFilterType, bloomFilterVectorSize, bloomFilterNbHashes}).
> {code}
> The generated record should have default values added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to