[
https://issues.apache.org/jira/browse/THRIFT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607743#action_12607743
]
David Reiss commented on THRIFT-54:
-----------------------------------
Yeah. setRead was deleted from TFramedTransport since it was so poorly
implemented that I couldn't imagine anyone using it (and it was getting in the
way of the buffered transports refactor). I don't think there is any need to
re-implement it. I'd be fine with getting rid of frameResponses_ from the
TNonblockingServer also.
> test/cpp doesn't compile
> ------------------------
>
> Key: THRIFT-54
> URL: https://issues.apache.org/jira/browse/THRIFT-54
> Project: Thrift
> Issue Type: Bug
> Components: Test Suite
> Reporter: Alexander Shigin
> Priority: Minor
>
> make -f Makefile.thrift fails with
> src/TestClient.cpp:69: class facebook::thrift::transport::TFramedTransport'
> has no member named 'setRead'
> I can't find any mentions about setRead in lib/cpp/transport. I can solve the
> issue by removing this line.
> I have a question: does setRead go out or some people will implement it? If
> nobody need it should we delete frameResponses_ from TNonblockingServer?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
