[
https://issues.apache.org/jira/browse/THRIFT-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607822#action_12607822
]
Kevin Clark commented on THRIFT-57:
-----------------------------------
Works for me. Barring objection, I'll push soonish.
> Generated thrift code relies on gen-rb being in $:
> --------------------------------------------------
>
> Key: THRIFT-57
> URL: https://issues.apache.org/jira/browse/THRIFT-57
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Priority: Minor
> Attachments:
> 0001-rb-Use-File.dirname-__FILE__-in-generated-requires.patch
>
>
> The generated thrift code for ruby relies on the gen-rb folder being in $:.
> The generated service definition and _constants file both have a bare require
> 'Name_types', which can't find the Name_types.rb file unless it's in $:. The
> generated code should be using File.dirname(__FILE__) to specify the path as
> relative to itself.
> The only problem here is any clients of the library which put gen-rb into $:
> and then require the Name_types file themselves will end up with warnings
> about redefining the FIELDS constant. This should be treated as a deprecation
> warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
